search

apple / ccs-calendarserver

The Calendar and Contacts Server.
https://www.calendarserver.org
Apache License 2.0
486 stars 136 forks source link

calendarserver_export uses CalDAVFile #186

Closed macosforgebot closed 13 years ago

macosforgebot commented 13 years ago

mail@… originally submitted this as ticket:406

Current trunk @r6886 uses in calendarserver_export the CalDAVFile from static.py.

This has been reomoved 6 months ago.

http://trac.calendarserver.org/browser/CalendarServer/trunk/twistedcaldav/static.py?rev=5966

macosforgebot commented 13 years ago

mail@… originally submitted this as comment:1:⁠ticket:406

The error message one gets for google to index:

Traceback (most recent call last):
  File "/usr/bin/calendarserver_export", line 43, in <module>
    from calendarserver.tools.export import main
  File "/usr/lib/python2.7/site-packages/calendarserver/tools/export.py", line 44, in <module>
    from twistedcaldav.static import CalDAVFile
ImportError: No module named static
macosforgebot commented 13 years ago

mail@… originally submitted this as comment:2:⁠ticket:406

--- ./calendarserver/tools/export.py    2011-02-04 21:20:12.824330578 +0100
+++ /usr/lib/python2.7/site-packages/calendarserver/tools/export.py     2011-02-05 02:38:16.531756689 +0100
@@ -41,7 +41,7 @@
 from twistedcaldav.ical import iCalendarProductID
 from twistedcaldav.resource import isCalendarCollectionResource,\
     CalendarHomeResource
-from twistedcaldav.static import CalDAVFile
+from twistedcaldav.resource import CalDAVResource
 from twistedcaldav.directory.directory import DirectoryService

 from calendarserver.tools.util import UsageError
macosforgebot commented 13 years ago

mail@… originally submitted this as comment:3:⁠ticket:406

My fix does not really solve the problem which requires way more work:

<fmms> glyph, just patched that have a look at the ticket
<glyph> fmms: it's not quite that simple
<fmms> at least then i can read the help ;)
<glyph> fmms: the data-store API is completely different now, CalDAVResource isn't backed by files on disk.  Even if you use the (unsupported) filesystem backend, it has a different API.
<glyph> yeah that tool just hasn't been updated yet
<glyph> it's not a matter of a single import, it needs to be rewritten :)
<fmms> glyph, i am just using the filesystem backend, why is it not supported?
<fmms> what does that mean, will you remove it any day, or will bugs be fixed slower?
<glyph> fmms: It means that you should use the database backend because that's the one that's supposed to work :).
macosforgebot commented 13 years ago

@wsanchez originally submitted this as comment:4:⁠ticket:406

macosforgebot commented 13 years ago

mail@… originally submitted this as comment:5:⁠ticket:406

I think this issue has been fixed at least partly by commit r7486 ??

One question why does this use /etc/cardavd/caldavd.plist instead of /etc/caldavd/caldavd.plist?

macosforgebot commented 13 years ago

@glyph originally submitted this as comment:6:⁠ticket:406

Replying to mail@…:

I think this issue has been fixed at least partly by commit r7486 ??

One question why does this use /etc/cardavd/caldavd.plist instead of /etc/caldavd/caldavd.plist?

Good catch! That was autocomplete gone wrong.

macosforgebot commented 13 years ago

@glyph originally submitted this as comment:7:⁠ticket:406

The wrong-default-config-file issue fixed in http://trac.calendarserver.org/changeset/7489.

Thanks for reporting the bug!