search

apple / ccs-calendarserver

The Calendar and Contacts Server.
https://www.calendarserver.org
Apache License 2.0
486 stars 136 forks source link

doQuery should call returnValue on return #303

Closed macosforgebot closed 13 years ago

macosforgebot commented 14 years ago

erb@… originally submitted this as ticket:382

In twistedcaldav/method/report_calquery.py the subfunction doQuery is declared with @inlineCallbacks, so it ought to call returnValue instead of return at line 184.

Also it should return True otherwise report_common.applyToCalendarCollections won't apply doQuery to all calendar collections.

A patch is included. This also applies to trunk, although the filename has been changed.

macosforgebot commented 14 years ago

erb@… originally submitted this as _attachment:report_calquery.patch:⁠ticket:382_

macosforgebot commented 14 years ago

apm@… originally submitted this as comment:1:⁠ticket:382

macosforgebot commented 13 years ago

@wsanchez originally submitted this as comment:2:⁠ticket:382

Fixed in 3.0