search

apple / ccs-calendarserver

The Calendar and Contacts Server.
https://www.calendarserver.org
Apache License 2.0
486 stars 136 forks source link

Missing 'ENODATA' in xattr.py on FreeBSD 9.x #382

Closed macosforgebot closed 8 years ago

macosforgebot commented 11 years ago

Axel.Rau@… originally submitted this as ticket:802

While testing my FreeBSD port on 9.1, I get:

File "...txdav/base/propertystore/xattr.py", line 53, in <module>

_ERRNO_NO_ATTR = errno.ENODATA

AttributeError: 'module' object has no attribute 'ENODATA'

Adding freebsd9 here, does the job:

if sys.platform in ("darwin", "freebsd8"):

macosforgebot commented 11 years ago

@wsanchez originally submitted this as comment:1:⁠ticket:802

Fixed in r10942.

But really you shouldn't care because the filesystem data store is SO VERY OBSOLETE.

macosforgebot commented 11 years ago

@wsanchez originally submitted this as comment:2:⁠ticket:802

macosforgebot commented 10 years ago

Axel.Rau@… originally submitted this as attachment:xattr.diff:⁠ticket:802

patch against trunk.

macosforgebot commented 10 years ago

Axel.Rau@… originally submitted this as comment:3:⁠ticket:802

Problem: We a are now at freebsd 10. Solution: Make patch version independant.

macosforgebot commented 8 years ago

Axel.Rau@… originally submitted this as comment:4:⁠ticket:802

Problem: While creating a FreeBSD port for calendarserver-7.0, I still get:

from txdav.base.propertystore.xattr import PropertyStore as XattrPropertyStore

File "/usr/local/lib/python2.7/site-packages/txdav/base/propertystore/xattr.py", line 53, in <module>

_ERRNO_NO_ATTR = errno.ENODATA

AttributeError: 'module' object has no attribute 'ENODATA' [caldav3:site-packages/calendarserver/tap] root# uname -a FreeBSD caldav3 10.1-RELEASE-p31 FreeBSD 10.1-RELEASE-p31 #⁠0: Wed Mar 16 18:39:20 UTC 2016 root@…:/usr/obj/usr/src/sys/GENERIC amd64

So please commit my above patch from 2014-10-20 to the codebase.

macosforgebot commented 8 years ago

@wsanchez originally submitted this as comment:5:⁠ticket:802

r15557

Under what circumstances do you see this? That code is pretty much obsolete.

macosforgebot commented 8 years ago

@wsanchez originally submitted this as comment:6:⁠ticket:802

macosforgebot commented 8 years ago

Axel.Rau@… originally submitted this as comment:7:⁠ticket:802

Replying to wsanchez@…:

r15557

Under what circumstances do you see this? That code is pretty much obsolete.

calendarserver_upgrade —help

> /usr/local/lib/python2.7/site-packages/txdav/caldav/datastore/sql.py(1247)Calendar()
-> @classmethod
(Pdb) c
Traceback (most recent call last):
  File "/usr/local/bin/calendarserver_upgrade", line 9, in <module>
    load_entry_point('CalendarServer==7.0', 'console_scripts', 'calendarserver_upgrade')()
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 547, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2720, in load_entry_point
    return ep.load()
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2380, in load
    return self.resolve()
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2386, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python2.7/site-packages/calendarserver/tools/upgrade.py", line 36, in <module>
    from calendarserver.tools.cmdline import utilityMain, WorkerService
  File "/usr/local/lib/python2.7/site-packages/calendarserver/tools/cmdline.py", line 21, in <module>
    from calendarserver.tap.util import checkDirectories
  File "/usr/local/lib/python2.7/site-packages/calendarserver/tap/util.py", line 90, in <module>
    from txdav.common.datastore.file import CommonDataStore as CommonFileDataStore
  File "/usr/local/lib/python2.7/site-packages/txdav/common/datastore/file.py", line 58, in <module>
    from txdav.base.propertystore.xattr import PropertyStore as XattrPropertyStore
  File "/usr/local/lib/python2.7/site-packages/txdav/base/propertystore/xattr.py", line 53, in <module>
    _ERRNO_NO_ATTR = errno.ENODATA
AttributeError: 'module' object has no attribute 'ENODATA'
macosforgebot commented 8 years ago

@wsanchez originally submitted this as comment:8:⁠ticket:802

OK, thanks. That should be fixed in r15559.