dependency detection improvements

apple / ccs-calendarserver

The Calendar and Contacts Server.

https://www.calendarserver.org

Apache License 2.0

485 stars 136 forks source link

dependency detection improvements #387

Closed macosforgebot closed 10 years ago

macosforgebot commented 10 years ago

tk@… originally submitted this as ticket:821

I'm currently trying to package CalendarServer for pkgsrc, and as a first step, I've made packages for the dependencies and then tried making CalendarServer accept them. For this, I needed the attached patches.

The first one fixes the detection of Nevow and PyCrypto -- the 'import' module names are slightly different than CalendarServer expects.

Additionally, I've added support to use pkg_resources to recognize modules. This helped finding some other modules (sorry, forgot which).

macosforgebot commented 10 years ago

tk@… originally submitted this as attachment:CalendarServer.diff:⁠ticket:821

Attachment CalendarServer.diff (1.2 KB) added

Patch fixing the described issues.

macosforgebot commented 10 years ago

exarkun@… originally submitted this as comment:1:⁠ticket:821

is nevow actually a CalendarServer dependency? It looks like it may have once been but the html generation code I see in CalendarServer now uses twisted.web.template instead. I can't find any imports from the nevow package.

Perhaps the fix for Nevow in this patch should instead be to entirely drop it as a dependency from the build system.

macosforgebot commented 10 years ago

exarkun@… originally submitted this as attachment:dep-fixes-without-nevow.patch:⁠ticket:821

Attachment dep-fixes-without-nevow.patch (1.3 KB) added

previous patch, updated to apply against HEAD and to delete the nevow dependency instead of trying to fix it

macosforgebot commented 10 years ago

@wsanchez originally submitted this as comment:2:⁠ticket:821

r12260 for the pkg_resources thing.

macosforgebot commented 10 years ago

@wsanchez originally submitted this as comment:3:⁠ticket:821

r12261 to fix module package names.

macosforgebot commented 10 years ago

@wsanchez originally submitted this as comment:4:⁠ticket:821

IIRC we import nevow because of pydoctor, to make support/gendocs work.

macosforgebot commented 10 years ago

@wsanchez originally submitted this as comment:5:⁠ticket:821

Milestone set to CalendarServer-6.x

macosforgebot commented 10 years ago

@wsanchez originally submitted this as comment:6:⁠ticket:821

Status changed from new to closed
Resolution set to Software changed

build system is now all about using pip for python stuff; all of this has been replaced.