Closed macosforgebot closed 10 years ago
exarkun@… originally submitted this as attachment:define-own-timestamp.patch:ticket:825
This patch re-defines the value imported from twistedcaldav, removing the twistedcaldav dependency that twext.enterprise currently has
@wsanchez originally submitted this as comment:1:ticket:825
r10290 seems to have made the proposed change. That’s dated Jan 4, 2013, so… what version of the code are you using?
exarkun@… originally submitted this as comment:2:ticket:825
Oops, I was using the 4.2 release. Thanks.
exarkun@… originally submitted this as ticket:825
It's hard to find the version of PyCalendar that twistedcaldav works with. It doesn't appear to be the version at the svn repo referred to by https://pypi.python.org/pypi/Py-Calendar. Using that version fails with an import error for
pycalendar.timezonedb
.Since twext.enterprise only depends on twistedcaldav for the definition of
SQL_TIMESTAMP_FORMAT
(which appears not to be a part of thetwistedcaldav.dateops
public interface anyway) this seems like an easy dependency to remove.I'm all for code re-use and depending on other libraries. But only if those other libraries are actually available.
An equally satisfying resolution to this issue would be for twext.enterprise to depend on a particular, documented, released version of PyCalendar.