search

apple / ccs-calendarserver

The Calendar and Contacts Server.
https://www.calendarserver.org
Apache License 2.0
485 stars 136 forks source link

Check to ensure PSQL is available running command #480

Closed robarchibald closed 7 years ago

robarchibald commented 7 years ago

Tool currently crashes if PSQL isn't found in the path specified. Should gracefully exit with an error instead.

By submitting a request, you represent that you have the right to license your contribution to Apple and the community, and agree that your contributions are licensed under the Apache License Version 2.0.

For existing files modified by your request, you represent that you have retained any existing copyright notices and licensing terms. For each new file in your request, you represent that you have added to the file a copyright notice (including the year and the copyright owner's name) and the Calendar and Contacts Server's licensing terms.

Before submitting the request, please make sure that your request follows the Calendar and Contacts Server's guidelines for contributing code.

robarchibald commented 7 years ago

Adding in a documentation change to ensure that the admin guide includes all required dependencies.

dreness commented 7 years ago

We want all the setup to be /bin/sh / POSIX compliant, so I would like to root out any remaining issues where /bin/bash is required.

robarchibald commented 7 years ago

I think you've probably fixed the main bash-specific error in your earlier change. The true: unexpected operator error I saw wasn't bash-specific, but a bug that was already fixed in the mainline branch. I assumed that you expected the scripts to execute under bash so I started running everything explicitly under bash, but I will go back to running regularly and report any further issues and/or submit pull requests for what I find. Thanks!