Handle variable length APNS device tokens

apple / ccs-calendarserver

The Calendar and Contacts Server.

https://www.calendarserver.org

Apache License 2.0

484 stars 136 forks source link

Handle variable length APNS device tokens #496

Closed m0rgen closed 7 years ago

m0rgen commented 7 years ago

APNS device tokens are not fixed at 32 bytes in length. This patch packs/unpacks the structs we use for the binary APNS protocol to use dynamic token lengths. Unit tests for /calendarserver/push/ pass. I'm running full tests now.

dreness commented 7 years ago

Seems good; works in my manual testing.

I think the reason Travis did two builds of this is: one for the push (I must have configured it to build all branches) and another for the pull request. The PR one timed out, but that's not super surprising given that the test suite takes kind of a while to run, and would likely be subject to resource contention with other VM guests. I should probably split the tests into smaller chunks, which could then run in parallel.

cyrusdaboo commented 7 years ago

Looks OK to me.