search

apple / ccs-calendarserver

The Calendar and Contacts Server.
https://www.calendarserver.org
Apache License 2.0
484 stars 136 forks source link

Update URL of string #22 #517

Closed kant closed 5 years ago

kant commented 5 years ago

As far I know, there is no IRC support. URL has vanished.

By submitting a request, you represent that you have the right to license your contribution to Apple and the community, and agree that your contributions are licensed under the Apache License Version 2.0.

For existing files modified by your request, you represent that you have retained any existing copyright notices and licensing terms. For each new file in your request, you represent that you have added to the file a copyright notice (including the year and the copyright owner's name) and the Calendar and Contacts Server's licensing terms.

Before submitting the request, please make sure that your request follows the Calendar and Contacts Server's guidelines for contributing code.

dreness commented 5 years ago

Both the IRC and Mailing List URLs should redirect from the old URL to the new one, and in my testing, they do:

andre@youbeill[~]curl -s --head https://trac.calendarserver.org/MailingLists.html | egrep 'HTTP|Location|Via'
HTTP/1.1 301 Moved Permanently
Location: https://www.calendarserver.org/MailingLists.html
Via: https/1.1 ussjc2-edge-bx-013.ts.apple.com (ApacheTrafficServer/7.1.4)

andre@youbeill[~]curl -s --head https://trac.calendarserver.org/IRC.html | egrep 'HTTP|Location|Via'
HTTP/1.1 301 Moved Permanently
Location: https://www.calendarserver.org/IRC.html
Via: https/1.1 ussjc2-edge-bx-011.ts.apple.com (ApacheTrafficServer/7.1.4)

I tested this from multiple network positions - let me know if the redirect isn't working for you.

I'll update the PR to include both URLs. The IRC channel isn't exactly a hub of bustling activity and development, but it does still exist :)

Update: note that the redirect service faithfully preserves the presence or absence of a trailing slash in the URL. If a trailing slash is present, the request results in a 404.