search

apple / ccs-pykerberos

Python Kerberos library used by CalendarServer
https://www.calendarserver.org
Apache License 2.0
117 stars 65 forks source link

authGSSClientInit no longer accepts None for principal #49

Closed macosforgebot closed 7 years ago

macosforgebot commented 8 years ago

dcallagh@… originally submitted this as ticket:942

In r13269 the argument parsing for authGSSClientInit was (accidentally?) changed to no longer accept None for the principal argument.

This breaks the requests-kerberos module: https://github.com/requests/requests-kerberos/issues/76

Fix is trivial, change s back to z in the argument format string.

macosforgebot commented 8 years ago

dcallagh@… originally submitted this as attachment:942.patch:⁠ticket:942

proposed patch

kwlzn commented 8 years ago

+1 - we're hitting this issue at Twitter with the latest kerberos package.

what are the odds of getting this prioritized?