search

apple / ccs-pykerberos

Python Kerberos library used by CalendarServer
https://www.calendarserver.org
Apache License 2.0
117 stars 65 forks source link

Allow `authGSSClientInit` principal kwarg to be None. #52

Closed kwlzn closed 7 years ago

kwlzn commented 8 years ago

This PR simply applies the patch from https://github.com/apple/ccs-pykerberos/issues/49 for easier merging.

Fixes #49

dreness commented 8 years ago

Hi @kwlzn

We don't yet have any automated tests hooked up for this project. Some of the included tests require admin-level access to a kerberized service of some variety. If you happen to have such a configuration at your disposal, would you mind running through the included tests (with your patch applied) and posting your results?

I just added some testing notes to clarify how the tests are used, and the requirements / preconditions for each. Normally I wouldn't ask you to do this, but since I don't have an environment handy for this, and since you asked for expediting, this might be a chance to speed things along a bit. If not, that's fine too, I will just need to set up a test environment (which shouldn't take all that long...).

kwlzn commented 8 years ago

@dreness I unfortunately do not have admin-level access within our infra, sorry. :(

dreness commented 8 years ago

Just spent a lot of hours trying to get the tests to run against a system which I am now declaring to be too complicated for this purpose (apple's Server.app web service). I will try to find the simplest docker thing that I can find instead; unfortunately I don't remember exactly what I used last time.

cyrusdaboo commented 7 years ago

This change looks OK to me.