apple / ccs-pykerberos

Python Kerberos library used by CalendarServer
https://www.calendarserver.org
Apache License 2.0
117 stars 65 forks source link

Fix building on older Pythons #60

Closed behackett closed 7 years ago

behackett commented 7 years ago

This change fixes building on Python 2.4 (the oldest I have available) through 2.6 and 3.1. It also fixes a few compiler warnings.

By submitting a request, you represent that you have the right to license your contribution to Apple and the community, and agree that your contributions are licensed under the Apache License Version 2.0.

For existing files modified by your request, you represent that you have retained any existing copyright notices and licensing terms. For each new file in your request, you represent that you have added to the file a copyright notice (including the year and the copyright owner's name) and the Calendar and Contacts Server's licensing terms.

Before submitting the request, please make sure that your request follows the Calendar and Contacts Server's guidelines for contributing code.

behackett commented 7 years ago

My main goal here was to re-enable support for Python 2.6 so projects like PyMongo and requests-kerberos can switch back to ccs-pykerberos from various forks. Supporting Python 2.4 and 2.5 just happens to be the same change.

jborean93 commented 7 years ago

Have tested this manually without any errors against the following versions;

behackett commented 7 years ago

@dreness - any comment on this?

dreness commented 7 years ago

I'm going to do the thing where I merge something right before going offline, in this case for two weeks. But, I don't think this is too risky, plus the tests are passing :)