apple / ccs-pykerberos

Python Kerberos library used by CalendarServer
https://www.calendarserver.org
Apache License 2.0
117 stars 65 forks source link

Replace asprintf with snprintf in kerberospw.c #78

Open traveltissues opened 5 years ago

traveltissues commented 5 years ago

asprintf is a gnu extension function. This commit replaces calls to this with a call to the standard snprintf function when reporting errors in the change_user_krb5pwd function.

By submitting a request, you represent that you have the right to license your contribution to Apple and the community, and agree that your contributions are licensed under the Apache License Version 2.0.

For existing files modified by your request, you represent that you have retained any existing copyright notices and licensing terms. For each new file in your request, you represent that you have added to the file a copyright notice (including the year and the copyright owner's name) and the Calendar and Contacts Server's licensing terms.

Before submitting the request, please make sure that your request follows the Calendar and Contacts Server's guidelines for contributing code.

traveltissues commented 5 years ago

@dreness I've removed the ws change (https://github.com/apple/ccs-pykerberos/compare/a4248ad387f3090fd459d3d1c702a884ef9028fa..9147b64947461152a68729390feffd5f6cecd03f). This change would be useful downstream for some packages relying on pykerberos on non-linux, thanks.