TobyRoseman
commented
3 years ago @tommy19970714 - thanks for the succinct example. I can reproduce this issue. Here is the stack trace:
Converting Frontend ==> MIL Ops: 52%|████████████████████████████████████▌ | 12/23 [00:00<00:00, 6845.05 ops/s]
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
<ipython-input-1-0dc5b90d7ed5> in <module>
19 coreml_model = ct.convert(
20 trace_model,
---> 21 inputs=[ct.TensorType(name="x", shape=input.shape, dtype=types.float)]
22 )
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/_converters_entry.py in convert(model, source, inputs, outputs, classifier_config, minimum_deployment_target, convert_to, **kwargs)
180 outputs=outputs,
181 classifier_config=classifier_config,
--> 182 **kwargs
183 )
184
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/converter.py in mil_convert(model, convert_from, convert_to, **kwargs)
127 """
128 proto = mil_convert_to_proto(model, convert_from, convert_to,
--> 129 ConverterRegistry, **kwargs)
130 if convert_to == 'mil':
131 return proto
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/converter.py in mil_convert_to_proto(model, convert_from, convert_to, converter_registry, **kwargs)
169 frontend_converter = frontend_converter_type()
170
--> 171 prog = frontend_converter(model, **kwargs)
172 common_pass(prog)
173
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/converter.py in __call__(self, *args, **kwargs)
83 from .frontend.torch import load
84
---> 85 return load(*args, **kwargs)
86
87
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/frontend/torch/load.py in load(model_spec, debug, **kwargs)
81 raise e
82 except Exception as e:
---> 83 raise e
84
85 return prog
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/frontend/torch/load.py in load(model_spec, debug, **kwargs)
71
72 try:
---> 73 prog = converter.convert()
74 except RuntimeError as e:
75 if debug and "convert function" in str(e):
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/frontend/torch/converter.py in convert(self)
225
226 # Add the rest of the operations
--> 227 convert_nodes(self.context, self.graph)
228
229 graph_outputs = [self.context[name] for name in self.graph.outputs]
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/frontend/torch/ops.py in convert_nodes(context, graph)
56 )
57 else:
---> 58 _add_op(context, node)
59
60 # We've generated all the outputs the graph needs, terminate conversion.
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/frontend/torch/ops.py in view(context, node)
854 shape = mb.concat(values=shape, axis=0)
855
--> 856 view = mb.reshape(x=x, shape=shape, name=node.name)
857 context.add(view)
858
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/mil/ops/registry.py in add_op(cls, **kwargs)
60 @classmethod
61 def add_op(cls, **kwargs):
---> 62 return cls._add_op(op_cls, **kwargs)
63
64 setattr(Builder, op_type, add_op)
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/mil/builder.py in _add_op(cls, op_cls, **kwargs)
172 op_name=kwargs["name"], before_op=before_op,
173 candidate_kv=kwargs))
--> 174 new_op = op_cls(**kwargs)
175
176 # Initialize optional input Vars if it wasn't in kwargs
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/mil/ops/defs/tensor_transformation.py in __init__(self, **kwargs)
190
191 def __init__(self, **kwargs):
--> 192 super(reshape, self).__init__(**kwargs)
193
194 def type_inference(self):
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/mil/operation.py in __init__(self, **kwargs)
168 input_kv = {k: v for k, v in kwargs.items() \
169 if k in self._input_types and v is not None}
--> 170 self._validate_and_set_inputs(input_kv)
171 self._ensure_required_inputs()
172
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/mil/operation.py in _validate_and_set_inputs(self, input_kvs, no_check_var_types)
453 v_old.remove_child_op(op, no_check_var_types)
454
--> 455 self.input_spec.validate_inputs(self.name, self.op_type, input_kvs)
456
457 for name, var in input_kvs.items():
~/opt/miniconda3/envs/test/lib/python3.7/site-packages/coremltools/converters/mil/mil/input_type.py in validate_inputs(self, op_name, op_type, candidate_kvs)
119 "{} but got {}"
120 raise ValueError(msg.format(name, var.name, input_type.type_str,
--> 121 var.sym_type.__type_info__()))
122
123
ValueError: Op "13" (op_type: reshape) Input shape="12" expects integer tensor but got tensor[0,fp32]
🐞Describe the bug
I got the following error when I tried to convert the coreml model from the pytorch model. If you run
x[:, :] = 0aftertorch.cat, the coreml conversion will fail.Trace
To Reproduce
Here is a colab to reproduce. https://colab.research.google.com/drive/1eR3HLQh5zdPQzg9rMFt641NH7h7T85bE?usp=sharing
System environment (please complete the following information):
Additional context
I wrote the following, and it worked fine.