search

apple / corenet

CoreNet: A library for training deep neural networks
Other
6.72k stars 518 forks source link

Update setup.py #15

Closed AssiamahS closed 1 month ago

AssiamahS commented 2 months ago

The code looks mostly good, but there are a few minor spelling errors and improvements that can be made for clarity and consistency:

In the comment block at the beginning, "copyright" is misspelled as "copyrigth." "parse_requirements" function: The function name and docstring should be consistent with the British English spelling of "requirements." "is_internal" variable: The variable name is clear, but consider adding a comment explaining its purpose. "dev_requirement_regex" variable: "Requirement" should be pluralized as "Requirements" for consistency. In the setup function: "python_requires" should specify the minimum required Python version as ">=3.6" since the code checks for Python 3.6 compatibility. "setuptools" version should be specified as "setuptools>=18.0" for consistency with other requirements.

mohammad7t commented 2 months ago

The diff seems to be empty now. I think https://github.com/apple/corenet/pull/15/commits/ecbece3c603777e3523620cc9f5bc204e9778990 looked good except line 92

mohammad7t commented 1 month ago

Closing for inactivity. Please feel free to re-open it after updating the PR.