apple / corenet

CoreNet: A library for training deep neural networks
Other
6.94k stars 540 forks source link

[Issue #14] Recommend explicit mentioning of Python version for creating virtual environment #16

Closed rezashahnazar closed 5 months ago

rezashahnazar commented 5 months ago

Clarified in README.md that Python version 3.11 is recommended for creating the virtual environment using venv. This ensures compatibility with the current version and allows for future flexibility.

mohammad7t commented 5 months ago

Thank you very much for your contribution, @rezashahnazar .

Currently, we can confirm that CoreNet can be installed on python-3.9, as specified in https://github.com/apple/corenet/blob/main/tox.ini. Apparently, there is an issue with python-3.12 that is reported on https://github.com/apple/corenet/issues/14.

We prefer to make CoreNet installable on all python versions >=3.9, including 3.12, if possible. Thus, I'm closing this PR but will keep https://github.com/apple/corenet/issues/14 open and please feel free to open a PR that fixes the issue with all 3.9+ versions including 3.12.