URL encoding problems with admin.cgi (when using umlauts umlauts)

[michaelrsweet]

Version: 1.1.19rc4 CUPS.org User: thomas.kaiser.phg-online

After creating a printer called "täst" I haven't been able to administrate it via admin.cgi and a browser running on a macintosh or windows.

The name of the queue will be displayed correctly but the URL is wrong: "t%st" instead of "t%E4st".

So all operations like eg.

"...:631/admin/?op=start-printer&printer_name=t%st" 

will fail because the name of the queue cannot be recognized by the admin.cgi itself. In error_log appears a line

start_printer: resource name '/printers/tst' no good!

On windows the name is displayed incorrectly and the printer cannot be found, too (seems like Unicode is used):

get_printer_attrs: resource name '/printers/tÀst' no good!
get_jobs: resource name '/printers/tÀst' no good!

If I try it locally on linux everything works as expected:

Printer 'täst' stopped by 'root'.
Printer 'täst' started by 'root'.

[michaelrsweet]

CUPS.org User: mike

Fixed in CVS for 1.1.20; see attached patch.

[michaelrsweet]

"str120.patch":

Index: ipp-var.c

RCS file: /development/cvs/cups/cgi-bin/ipp-var.c,v retrieving revision 1.34 diff -u -r1.34 ipp-var.c --- ipp-var.c 2003/04/08 03:45:14 1.34 +++ ipp-var.c 2003/06/14 16:51:08 @@ -101,13 +101,19 @@ char method[HTTP_MAX_URI], username[HTTP_MAX_URI], hostname[HTTP_MAX_URI],

• rawresource[HTTP_MAX_URI], resource[HTTP_MAX_URI],
• uri[HTTP_MAX_URI];
• uri[HTTP_MAX_URI],
• rawptr, / Pointer into rawresource */
• resptr; / Pointer into resource / int port; / URI data / int ishttps; / Using encryption? / const char *server; / Name of server */
• char servername[1024];/* Locale server name */
• char servername[1024];
• /* Locale server name / struct tm *date; / Date information */
• static const char hexchars[] = "0123456789ABCDEF";

•             /* Hexadecimal conversion characters */

  DEBUG_printf(("

  ippSetCGIVars(response=%p, filter_name=\"%s\", filter_value=\"%s\", prefix=\"%s\")\n", @@ -270,12 +276,36 @@ case IPP_TAG_URI : if (strchr(attr->values[i].string.text, ':') != NULL) {

• /*
• * Rewrite URIs...
• */ + httpSeparate(attr->values[i].string.text, method, username,
• hostname, &port, resource);

•              hostname, &port, rawresource);
  
    if (strcmp(method, "ipp") == 0 ||
        strcmp(method, "http") == 0)
    {

• /*
• * Rewrite the resource string so it doesn't contain any
• * illegal chars...
• */ +
• for (rawptr = rawresource, resptr = resource; *rawptr;)
• if (rawptr & 128 || rawptr == '%' || *rawptr == ' ')
• {
• if (resptr < (resource + sizeof(resource) - 3))
• {
• *resptr++ = '%';
• _resptr++ = hexchars[(_rawptr >> 4) & 15];
• _resptr++ = hexchars[_rawptr & 15];
• }
• }
• else if (resptr < (resource + sizeof(resource) - 1))
• resptr++ = rawptr++; +
• resptr = '\0'; + / * Map local access to a local URI... */