hpgltops takes all resources and print never completes when printing certain type files

[michaelrsweet]

Version: 1.2-current CUPS.org User: hdearing

Whenever we send a certain type of file to a cups print queue, hpgltops starts and claims most or all of the resources and then never finishes and we never get a printout. The file contains pcl and it looks like hpgl.

[michaelrsweet]

CUPS.org User: hdearing

We purchased cups from Easy Software Products. How do we go about getting support? In posting STR#1415 I got an email that says that I am not a member and may not be able to post to a members only list. Thank you in advance.

[michaelrsweet]

CUPS.org User: mike

The message you got was from the cups-bugs list moderation system; basically, unless you are subscribed to cups-bugs, we have to approve your posting which happens automatically when you post a STR.

ESP Print Pro support is available at:

http://www.easysw.com/support.php

That said, the PCL file you are trying to print will not work with the HP-GL/2 filter. It should clearly not consume all CPU, however, so we'll look at fixing this in CUPS 1.2/ESP Print Pro 5.

To print this file, use the "-oraw" option when printing.

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

[michaelrsweet]

"str1415.patch":

Index: hpgl-input.c

--- hpgl-input.c (revision 5146) +++ hpgl-input.c (working copy) @@ -3,7 +3,7 @@ *

• HP-GL/2 input processing for the Common UNIX Printing System (CUPS). *
  • * Copyright 1993-2005 by Easy Software Products.
  • * Copyright 1993-2006 by Easy Software Products.
• These coded instructions, statements, and computer programs are the

• property of Easy Software Products and are protected by Federal @@ -125,6 +125,9 @@

  default : /* HP RTL/PCL control */
     while ((i = getc(fp)) != EOF && !isupper(i & 255));

  +

  • if (i == EOF)
  • return (-1); break; } } while (ch < ' '); @@ -133,8 +136,20 @@ name[1] = getc(fp); name[2] = '\0';
• if (strcasecmp(name, "LB") == 0)
• if (name[1] < ' ') {
• /*
• * If we get here, then more than likely we are faced with a raw PCL
• * file which we can't handle - abort!
• */ +
• fputs("ERROR: Invalid HP-GL/2 command seen, unable to print file!\n",
• stderr);
• return (-1);
• } +
• if (!strcasecmp(name, "LB"))
• { bufptr = buf; while ((ch = getc(fp)) != StringTerminator) if (bufptr < (buf + sizeof(buf) - 1)) @@ -145,7 +160,7 @@ p[num_params].value.string = strdup(buf); num_params ++; }
• else if (strcasecmp(name, "SM") == 0)
• else if (!strcasecmp(name, "SM")) { buf[0] = getc(fp); buf[1] = '\0'; @@ -153,7 +168,7 @@ p[num_params].value.string = strdup(buf); num_params ++; }
• else if (strcasecmp(name, "DT") == 0)
• else if (!strcasecmp(name, "DT")) { if ((buf[0] = getc(fp)) != ';') { @@ -163,7 +178,7 @@ num_params ++; } }
• else if (strcasecmp(name, "PE") == 0)
• else if (!strcasecmp(name, "PE")) { bufptr = buf; while ((ch = getc(fp)) != ';')