michaelrsweet commented 18 years ago

Version: 8.15-current CUPS.org User: twaugh.redhat

Not sure where exactly the problem is here, but the printer asks for Letter paper when an A4 job was sent. It's not a hardware configuration issue: I can see in the error_log that Letter page size is sent.

Original bug report: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191601

The problem comes when using the laserjet.ppd.gz PPD that ships with CUPS, although the problem might be in pstoraster or somewhere else.

michaelrsweet commented 18 years ago

CUPS.org User: mike

Please get a copy of the PostScript file the user is using to test with. The PS file is apparently setting the media size to Letter - the pstops filter is reporting the (correct) default media size A4...

michaelrsweet commented 18 years ago

CUPS.org User: mike

OK, I just tested things with the PPD file, output.ps file, current pstops filter, and ESP Ghostscript 7.07.1 and 8.15.x - the older ESP Ghostscript produced an A4 raster image, but 8.15.x produced a letter-sized raster image.

This is an ESP Ghostscript bug, not a CUPS bug...

michaelrsweet commented 18 years ago

CUPS.org User: mike

OK, the policy stuff they added is the cause of the problem. Policy "3" means "select the nearest page size", which for a Ghostscript driver means the default size (which is letter).

I've attached a patch that seems to fix things for this test file (basically matching policy 3 to impose the size...)

michaelrsweet commented 17 years ago

"str1794.patch":

Index: src/zmedia2.c

--- src/zmedia2.c (revision 188) +++ src/zmedia2.c (working copy) @@ -345,99 +345,24 @@

 if ((rx <= 0) || (ry <= 0))
return_error(e_rangecheck);

if (policy == 7) {
/* (Adobe) hack: just impose requested values */
*best_mismatch = 0;
gs_make_identity(pmat);
pmsize = request;
} else {
int fit_direct = rx - medium->p.x >= -5 && rx - medium->q.x <= 5
&& ry - medium->p.y >= -5 && ry - medium->q.y <= 5;
int fit_rotated = rx - medium->p.y >= -5 && rx - medium->q.y <= 5

- && ry - medium->p.x >= -5 && ry - medium->q.x <= 5;

/* Fudge matches from a non-standard page size match (4 element array) */
/* as worse than an exact match from a standard (2 element array), but */
/* better than for a rotated match to a standard pagesize. This should */
/* prevent rotation unless we have to (particularly for raster file */
/* formats like TIFF, JPEG, PNG, PCX, BMP, etc. and also should allow */
/* exact page size specification when there is a range PageSize entry. */
/* As the comment in gs_setpd.ps says "Devices that care will provide */
/* a real InputAttributes dictionary (most without a range pagesize) */
if ( fit_direct && fit_rotated) {
make_adjustment_matrix(request, medium, pmat, false, orient < 0 ? 0 : orient);
if (medium->p.x < medium->q.x || medium->p.y < medium->q.y)
_bestmismatch = (float)0.001; / fudge a match to a range as a small number */
else /* should be 0 for an exact match */
best_mismatch = fabs((rx - medium->p.x) \ (medium->q.x - rx)) +
fabs((ry - medium->p.y) * (medium->q.y - ry));
} else if ( fit_direct ) {

     int rotate = orient < 0 ? 0 : orient;

make_adjustment_matrix(request, medium, pmat, false, (rotate + 1) & 2);

best_mismatch = fabs((medium->p.x - rx) \ (medium->q.x - rx)) +
fabs((medium->p.y - ry) * (medium->q.y - ry)) +
(pmat->xx == 0.0 || (rotate & 1) == 1 ? 0.01 : 0); /* rotated */
} else if ( fit_rotated ) {
int rotate = (orient < 0 ? 1 : orient);
/*
* M. Sweet (Easy Software Products)
*
* Since no Ghostscript driver actually lists its supported page
* sizes, anything other than "impose" will yield the default page
* size that was compiled into Ghostscript, which is usually Letter.
*
* Since this is not the expected or intended behavior, we have
* dropped the media size matching code in favor of just imposing
* the selected size.
```
*/
```

make_adjustment_matrix(request, medium, pmat, false, rotate | 1);

best_mismatch = fabs((medium->p.y - rx) \ (medium->q.y - rx)) +
fabs((medium->p.x - ry) * (medium->q.x - ry)) +
(pmat->xx == 0.0 || (rotate & 1) == 1 ? 0.01 : 0); /* rotated */
} else {
int rotate =
(orient >= 0 ? orient :
(rx < ry) ^ (medium->q.x < medium->q.y));
bool larger =
(rotate & 1 ? medium->q.y >= rx && medium->q.x >= ry :
medium->q.x >= rx && medium->q.y >= ry);
bool adjust = false;
float mismatch = medium->q.x * medium->q.y - rx * ry;
/* (Adobe) hack: just impose requested values */
*best_mismatch = 0;
gs_make_identity(pmat);
pmsize = request;
```
switch (policy) {
```
default: /* exact match only */
return 0;
case 3: /* nearest match, adjust */
adjust = true;
case 5: /* nearest match, don't adjust */
if (fabs(mismatch) >= fabs(*best_mismatch))
return 0;
break;
case 4: /* next larger match, adjust */
adjust = true;
case 6: /* next larger match, don't adjust */
if (!larger || mismatch >= *best_mismatch)
return 0;
break;
}
if (adjust)
make_adjustment_matrix(request, medium, pmat, !larger, rotate);
else {
gs_rect req_rect;
if(rotate & 1) {
req_rect.p.x = ry;
req_rect.p.y = rx;
} else {
req_rect.p.x = rx;
req_rect.p.y = ry;
}
req_rect.q = req_rect.p;
make_adjustment_matrix(request, &req_rect, pmat, false, rotate);
}
*best_mismatch = fabs(mismatch);
}
if (pmat->xx == 0) { /* Swap request X and Y. */

- double temp = rx;

rx = ry, ry = temp;
} -#define ADJUST_INTO(req, mmin, mmax)\
(req < mmin ? mmin : req > mmax ? mmax : req)
pmsize->x = ADJUST_INTO(rx, medium->p.x, medium->q.x);
pmsize->y = ADJUST_INTO(ry, medium->p.y, medium->q.y); -#undef ADJUST_INTO
} return 1; } /*

apple / cups

Wrong page size with laserjet.ppd #1794

Index: src/zmedia2.c

- && ry - medium->p.x >= -5 && ry - medium->q.x <= 5;

- double temp = rx;