libcups.a installed with 555 permissions, making ranlib fail

[michaelrsweet]

Version: 1.4-current CUPS.org User: fhimpe.telenet

When building cups svn, it fails because libcups.a is installed with 555 permissions (I guess because of INSTALL_LIB = $(LIBTOOL) $(INSTALL) -c -m 555 @INSTALL_STRIP@ in Makedefs.in). After libcups.a is installed, ranlib is run on the installed file, but then it fails because the file is unwritable.

make[1]: Entering directory `/home/fhimpe/cups/BUILD/cups-1.4svn-r8684/cups' /home/fhimpe/cups/BUILD/cups-1.4svn-r8684/install-sh -d -m 755 /home/fhimpe/cups/BUILDROOT/cups-1.4.0-0.8684.1mdv2010.0.i386/usr/lib /home/fhimpe/cups/BUILD/cups-1.4svn-r8684/install-sh -c -m 555 -s libcups.a /home/fhimpe/cups/BUILDROOT/cups-1.4.0-0.8684.1mdv2010.0.i386/usr/lib ranlib /home/fhimpe/cups/BUILDROOT/cups-1.4.0-0.8684.1mdv2010.0.i386/usr/lib/libcups.a ranlib: unable to copy file '/home/fhimpe/cups/BUILDROOT/cups-1.4.0-0.8684.1mdv2010.0.i386/usr/lib/libcups.a'; reason: Permission denied make[1]: *\ [installstatic] Error 1

[michaelrsweet]

CUPS.org User: mike

P2, as this only affects non-root installs on old systems that still ship and require a ranlib command to be run...

Will look into some possible solutions (we still want mode 555 for the final permissions...)

[michaelrsweet]

CUPS.org User: mike

Also, static libraries are no longer installed by default...

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

[michaelrsweet]

"str3209.patch":

Index: Makedefs.in

--- Makedefs.in (revision 8685) +++ Makedefs.in (working copy) @@ -20,6 +20,7 @@ AR = @AR@ AWK = @AWK@ CC = @LIBTOOL@ @CC@ +CHMOD = @CHMOD@ CXX = @LIBTOOL@ @CXX@ DSO = @DSO@ DSOXX = @DSOXX@

Index: config-scripts/cups-common.m4

--- config-scripts/cups-common.m4 (revision 8685) +++ config-scripts/cups-common.m4 (working copy) @@ -49,6 +49,7 @@ AC_PROG_CXX AC_PROG_RANLIB AC_PATH_PROG(AR,ar) +AC_PATH_PROG(CHMOD,chmod) AC_PATH_PROG(HTMLDOC,htmldoc) AC_PATH_PROG(LD,ld) AC_PATH_PROG(LN,ln)

Index: driver/Makefile

--- driver/Makefile (revision 8685) +++ driver/Makefile (working copy) @@ -164,8 +164,9 @@

installstatic: $(INSTALL_DIR) -m 755 $(LIBDIR)

• $(INSTALL_LIB) libcupsdriver.a $(LIBDIR)
• $(INSTALL_LIB) -m 755 libcupsdriver.a $(LIBDIR) $(RANLIB) $(LIBDIR)/libcupsdriver.a

• $(CHMOD) 555 $(LIBDIR)/libcupsdriver.a

  #

  Index: cups/Makefile

  --- cups/Makefile (revision 8685) +++ cups/Makefile (working copy) @@ -237,8 +237,9 @@

  installstatic: $(INSTALL_DIR) -m 755 $(LIBDIR)

• $(INSTALL_LIB) libcups.a $(LIBDIR)
• $(INSTALL_LIB) -m 755 libcups.a $(LIBDIR) $(RANLIB) $(LIBDIR)/libcups.a

• $(CHMOD) 555 $(LIBDIR)/libcups.a

  install32bit: echo Installing libraries in $(LIB32DIR)...

  Index: filter/Makefile

  --- filter/Makefile (revision 8685) +++ filter/Makefile (working copy) @@ -164,8 +164,9 @@

  installstatic: $(INSTALL_DIR) -m 755 $(LIBDIR)

• $(INSTALL_LIB) libcupsimage.a $(LIBDIR);
• $(RANLIB) $(LIBDIR)/libcupsimage.a;
• $(INSTALL_LIB) -m 755 libcupsimage.a $(LIBDIR)
• $(RANLIB) $(LIBDIR)/libcupsimage.a

• $(CHMOD) 555 $(LIBDIR)/libcupsimage.a

  install32bit: $(INSTALL_DIR) -m 755 $(LIB32DIR)

  Index: ppdc/Makefile

  --- ppdc/Makefile (revision 8685) +++ ppdc/Makefile (working copy) @@ -182,8 +182,9 @@

  installstatic: $(INSTALL_DIR) -m 755 $(LIBDIR)

• $(INSTALL_LIB) libcupsppdc.a $(LIBDIR)
• $(INSTALL_LIB) -m 755 libcupsppdc.a $(LIBDIR) $(RANLIB) $(LIBDIR)/libcupsppdc.a

• $(CHMOD) 555 $(LIBDIR)/libcupsppdc.a

  #

  Index: cgi-bin/Makefile

  --- cgi-bin/Makefile (revision 8685) +++ cgi-bin/Makefile (working copy) @@ -158,8 +158,9 @@

  installstatic: $(INSTALL_DIR) -m 755 $(LIBDIR)

• $(INSTALL_LIB) libcupscgi.a $(LIBDIR)
• $(INSTALL_LIB) -m 755 libcupscgi.a $(LIBDIR) $(RANLIB) $(LIBDIR)/libcupscgi.a

• $(CHMOD) 555 $(LIBDIR)/libcupscgi.a

  #

  Index: scheduler/Makefile

  --- scheduler/Makefile (revision 8685) +++ scheduler/Makefile (working copy) @@ -225,8 +225,9 @@

  installstatic: $(INSTALL_DIR) -m 755 $(LIBDIR)

• $(INSTALL_LIB) libcupsmime.a $(LIBDIR)
• $(INSTALL_LIB) -m 755 libcupsmime.a $(LIBDIR) $(RANLIB) $(LIBDIR)/libcupsmime.a

• $(CHMOD) 555 $(LIBDIR)/libcupsmime.a

  #