search

apple / cups

Apple CUPS Sources
https://www.cups.org
Apache License 2.0
1.85k stars 452 forks source link

config-scripts #3346

Closed michaelrsweet closed 14 years ago

michaelrsweet commented 14 years ago

Version: 1.4.1 CUPS.org User: impulze

The config-scripts/cups-common.m4 file probes for the DBus Glib bindings although they are never used (line 269 and following), is this intended or a mistake?

michaelrsweet commented 14 years ago

CUPS.org User: mike

AFAIK the dbus APIs have a glib dependency, so even though we never directly use glib we still need to link against it. If this isn't correct, let me know and I'll happily remove the glib stuff.

There may also be some future direct use of glib in order to support Avahi in cupsd as well.

michaelrsweet commented 14 years ago

CUPS.org User: impulze

No, dbus does not have any glib dependency. Even if they did (which they don't :P) dbus-glib would be unnecessary, I'm just wondering because currently source-based distributions will end up with a automagic dependency i.e. it will link against glib and dbus-glib if present although it was probably not supposed to. Of course it could be that this is something planned for future cups releases when you actually make use of the glib bindings. I'm willing to provide a patch for the current situation if it has a chance to get applied. Thanks for the quick response.

michaelrsweet commented 14 years ago

CUPS.org User: mike

Thanks, I'll just remove the glib check from the current 1.4.x branch and leave it in 1.5.x where we hopefully will get support for Avahi and will then need glib...

michaelrsweet commented 14 years ago

CUPS.org User: impulze

I've added the patch that I already had locally, you can use it then if you decide to. :-) Can be closed then, thanks.

michaelrsweet commented 14 years ago

CUPS.org User: mike

Fixed in Subversion repository.

michaelrsweet commented 14 years ago

"no_glib_if_dbus_is_used.patch":

diff -Naur branch-1.4/config-scripts/cups-common.m4 branch-1.4.new/config-scripts/cups-common.m4 --- branch-1.4/config-scripts/cups-common.m4 2009-09-25 18:44:18.000000000 +0200 +++ branch-1.4.new/config-scripts/cups-common.m4 2009-09-25 18:51:34.000000000 +0200 @@ -266,11 +266,8 @@ dbus_message_iter_init_append, AC_DEFINE(HAVE_DBUS_MESSAGE_ITER_INIT_APPEND),, $PKGCONFIG --libs dbus-1)

michaelrsweet commented 14 years ago

"str3346.patch":

Index: config-scripts/cups-common.m4

--- config-scripts/cups-common.m4 (revision 8835) +++ config-scripts/cups-common.m4 (working copy) @@ -266,11 +266,6 @@ dbus_message_iter_init_append, AC_DEFINE(HAVE_DBUS_MESSAGE_ITER_INIT_APPEND),, $PKGCONFIG --libs dbus-1)