search

apple / cups

Apple CUPS Sources
https://www.cups.org
Apache License 2.0
1.94k stars 464 forks source link

Mistake in rastertodymo.c #373

Closed michaelrsweet closed 21 years ago

michaelrsweet commented 21 years ago

Version: 1.1.19 CUPS.org User: m2meier.inno

I have an older DYMO LabelWriter Turbo. I tried a long time to get this device working with CUPS. While debugging my setup, I found a little mistake in "rastertodymo.c". The values for the label-length-command (ESC L) in function 'StartPage()' are supplied as lsb/msb. But according to my documentation of the LabelWriter Series it should be msb/lsb. This way my LabelWriter writes labels as I expect it.

rastertodymo.c, line 136, orginal printf("\033L%c%c", length, length >> 8);

rastertodymo.c, line 136, new printf("\033L%c%c", length >> 8, length);

I hope you can change this in the next release.

Markus

Markus Meier (m2meier@inno.ch)

i n n o t r o n i c Ingenieurbüro Markus Meier

Steinackerstrasse 2, 8152 Glattbrugg -Switzerland- Telefon +41 1 997 17 27 info@inno.ch

michaelrsweet commented 21 years ago

CUPS.org User: mike

Wow, good catch. I wonder why it works with our 330...

Anyways, I'm commiting the changes to CVS and they will be included in 1.1.20...