apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.33k stars 1.3k forks source link

fix signed int and overflow bugs #11273

Closed hfu94 closed 4 months ago

hfu94 commented 4 months ago

now timestamp has uint64 and page number starts at 1

simulation : 20240401-164704-haofu-249f9bb66e85638b

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

hfu94 commented 4 months ago

nightly is already failing the same way without my change https://a1391190.slack.com/archives/C02EG00EEJY/p1711711121503399

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

xis19 commented 4 months ago

This LRU2 would cause memory leak.

hfu94 commented 4 months ago

This LRU2 would cause memory leak.

yeah will fix in a follow up PR, LRU is for unit testing only though but i will fix it.