apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.33k stars 1.3k forks source link

[Release-7.3] Cherry-pick Enable Accumulative Checksum in MutationRef (#11225) #11281

Closed kakaiu closed 4 months ago

kakaiu commented 4 months ago

Cherry-pick ACS Index (PR https://github.com/apple/foundationdb/pull/11225) to release-7.3 to guarantee the downgrade compatibility from 7.4, similar to MutationChecksum feature.

Feature on: 20240405-003157-zhewang-23b09646a07dc913 compressed=True data_size=34888425 duration=4969776 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=1:29:34 sanity=False started=100000 stopped=20240405-020131 submitted=20240405-003157 timeout=5400 username=zhewang

Feature off: 20240405-003006-zhewang-ada6b9ade0623502 compressed=True data_size=34888438 duration=5580015 ended=100000 fail=2 fail_fast=10 max_runs=100000 pass=99998 priority=100 remaining=0 runtime=1:34:46 sanity=False started=100000 stopped=20240405-020452 submitted=20240405-003006 timeout=5400 username=zhewang

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

jzhou77 commented 4 months ago

Are the two failures with feature off related?

kakaiu commented 4 months ago

Are the two failures with feature off related?

They are not related.

In PhysicalShardMove.toml, QuietDatabaseConsistencyCheckStart keeps retrying for consistently failed to get information for quiet database. { "Severity": "10", "Time": "15216.265099", "DateTime": "2024-04-05T01:40:42Z", "Type": "QuietDatabaseConsistencyCheckStartError", "Machine": "3.4.3.3:1", "ID": "0000000000000000", "Error": "attribute_not_found", "ErrorDescription": "Attribute not found", "ErrorCode": "2014", "ThreadID": "10437258837474635769", "LogGroup": "default", "Roles": "TS" }

In PerpetualWiggleStorageMigration.toml, ConsistencyChecker keeps retrying for TestFailure: Event Severity="20" Time="599.733958" DateTime="2024-04-05T22:21:57Z" Type="TestFailure" Machine="[abcd::3:4:3:4]:1" ID="0000000000000000" Workload="QuiescentCheck" Reason="Consistency check: Storage server has wrong key-value store type" ThreadID="13943674367234774327" LogGroup="default" Roles="TS"

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

kakaiu commented 4 months ago

CI Clang is failed for Consistency check: Storage server has wrong key-value store type in PerpetualWiggleStorageMigration.toml test, which is not relevant to this PR. So, rekick the CI test.

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7