apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.33k stars 1.3k forks source link

Suppress ChosenMachine to fix simulation error(release-7.3) #11283

Closed hfu94 closed 4 months ago

hfu94 commented 4 months ago

backport https://github.com/apple/foundationdb/pull/11277

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

hfu94 commented 4 months ago

it seems it still have that error, i will have to test if it still fails after i increase the trace allowed.

hfu94 commented 4 months ago

now it fails for a different reason: it now indefinitely run ConsistencyCheck and eventually fail, the count of all logs are similar, there is no outlier logs having significantly more count.

hfu94 commented 4 months ago
trace.0.0.0.0.305556.1712443967.EDV7Cg.1.31.xml:<Event Severity="40" ErrorKind="Unset" Time="5388.372710" DateTime="2024-04-06T23:02:32Z" Type="TestFailure" Machine="[abcd::3:4:3:2]:1" ID="0000000000000000" Workload="QuiescentCheck" Reason="Consistency check: Storage server has wrong key-value store type" ThreadID="18199472092616994695" Backtrace="addr2line -e fdbserver.debug -p -C -f -i 0x556611d 0x55663e3 0x55605e4 0x398b5b0 0x39907d0 0x3991638 0x271d4f8 0x271cb5c 0x271e248 0x271da0c 0x1c09468 0x1c09287 0x5337fbd 0x5337893 0x1bb5018 0x542ca61 0x542c57a 0x32946cc 0x7f7b91281555" LogGroup="default" Roles="TS" />
hfu94 commented 4 months ago

so the test did not fail, but there is a log Workload="QuiescentCheck" Reason="Consistency check: Storage server has wrong key-value store type" with Severity="40" making it failed.

1 tests passed; 0 tests failed.
Waiting for DD to end...
Set perpetual_storage_wiggle=0 ...
Set perpetual_storage_wiggle=0 Done.

Unseed: 78803
Elapsed: 5523.313302 simsec, 602.685939 real seconds
1 SevError events logged
hfu94 commented 4 months ago

here is where it fails https://github.com/apple/foundationdb/blame/985d4765f2ca0d82c4f08479558b38b286f26a49/fdbserver/workloads/ConsistencyCheck.actor.cpp#L946-L953

hfu94 commented 4 months ago

conclusion: this test fails for two different reasons, one of them is fixed by this PR, the other is related to the logic of this test and causing consistency check to repetitively fail. It is possible that only with the second reason that the first symptom would manifest, but it should still be a good idea to limit the number of logs that is possible.

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 4 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7