apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store

https://apple.github.io/foundationdb/

Apache License 2.0

14.42k stars 1.31k forks source link

fix: golang docker compose example #11297

Closed linehk closed 5 months ago

linehk commented 5 months ago

When I run docker-compose up -d, I can't use http://localhost:8080/counter to test golang app.

This is because docker-compose.yaml does not expose the port, and fdb.cluster needs to replace the address with the container name.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[ ] The PR has a description, explaining both the problem and the solution.
[ ] The description mentions which forms of testing were done and the testing seems reasonable.
[ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci commented 5 months ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 57806ff62128fd35100fc169662bb46643c1737b
Duration 0:20:22
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 5 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 57806ff62128fd35100fc169662bb46643c1737b
Duration 0:34:48
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 5 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 57806ff62128fd35100fc169662bb46643c1737b
Duration 0:46:11
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 5 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 57806ff62128fd35100fc169662bb46643c1737b
Duration 0:53:06
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 5 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 57806ff62128fd35100fc169662bb46643c1737b
Duration 1:29:58
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 5 months ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 57806ff62128fd35100fc169662bb46643c1737b
Duration 1:37:12
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)