apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store

https://apple.github.io/foundationdb/

Apache License 2.0

14.19k stars 1.29k forks source link

Hex decode add-prefix and remove-prefix for fdbrestore. #11344

Closed newhook closed 2 months ago

newhook commented 2 months ago

This is fix for https://github.com/apple/foundationdb/issues/1537.

--add-prefix and --remove-prefix command line arguments to fdbrestore are not hex decoded.

This also fixes a bug in the original decode_hex_string implementation where an error condition is not correctly flagged.

I tested the implementation locally and it works as expected.

Once this PR is merged I can create a fix against main.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[ ] The PR has a description, explaining both the problem and the solution.
[ ] The description mentions which forms of testing were done and the testing seems reasonable.
[ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci commented 2 months ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 5d3e226ac68d91b08c78130cf2f6c666c9ddeecd
Duration 0:32:44
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 months ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 5d3e226ac68d91b08c78130cf2f6c666c9ddeecd
Duration 0:44:58
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 5d3e226ac68d91b08c78130cf2f6c666c9ddeecd
Duration 0:47:04
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 5d3e226ac68d91b08c78130cf2f6c666c9ddeecd
Duration 0:53:04
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 2 months ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 5d3e226ac68d91b08c78130cf2f6c666c9ddeecd
Duration 1:03:08
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 months ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 146161a70be64b871d91dea6d8d4cca74bd21ff7
Duration 0:53:57
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 2 months ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 146161a70be64b871d91dea6d8d4cca74bd21ff7
Duration 1:15:34
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 months ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 146161a70be64b871d91dea6d8d4cca74bd21ff7
Duration 1:16:05
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

jzhou77 commented 1 month ago

@newhook , do you mind porting this to the main branch?

newhook commented 3 weeks ago

@newhook , do you mind porting this to the main branch?

https://github.com/apple/foundationdb/pull/11463