apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.19k stars 1.29k forks source link

Go binding: add StopNetwork() #11393

Open gm42 opened 1 month ago

gm42 commented 1 month ago

This PR contains the following notable changes:

  1. make sure that database creation is happening only while network thread is running
  2. panic if the call to fdb_run_network() fails, instead of logging an error only
  3. StartNetwork(), already deprecated, effectively becomes a no-op
  4. expose a new StopNetwork() method which allows to follow spec for issues like https://github.com/apple/foundationdb/issues/2978 and https://github.com/apple/foundationdb/issues/3015

Any advice for test coverage?

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

gm42 commented 1 month ago

Cc @vishesh @ajbeamon, as I saw you were involved in discussing #3015

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7