apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store

https://apple.github.io/foundationdb/

Apache License 2.0

14.19k stars 1.29k forks source link

Fix a segfault when tlog encounters platform_error [release-7.3] #11406

Closed jzhou77 closed 1 month ago

jzhou77 commented 1 month ago

cherrypick #11407

During destruction, rejoinClusterController actor should be cancelled to avoid accessing TLogData object.

Reproduction:

commit: c15448fac7 clang build seed: -f ./tests/rare/CycleWithKills.toml -s 4253735514 -b off

20240517-175903-jzhou-0d9d8397f18a09a7

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[ ] The PR has a description, explaining both the problem and the solution.
[ ] The description mentions which forms of testing were done and the testing seems reasonable.
[ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: b26dee432206aee3677be6982d7fd0cb34145335
Duration 0:32:49
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: b26dee432206aee3677be6982d7fd0cb34145335
Duration 0:45:14
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: b26dee432206aee3677be6982d7fd0cb34145335
Duration 0:48:21
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: b26dee432206aee3677be6982d7fd0cb34145335
Duration 1:34:01
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: b26dee432206aee3677be6982d7fd0cb34145335
Duration 1:38:45
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)