apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.19k stars 1.29k forks source link

Fix a segfault when tlog encounters platform_error #11407

Closed jzhou77 closed 1 month ago

jzhou77 commented 1 month ago

During destruction, rejoinClusterController actor should be cancelled to avoid accessing TLogData object.

20240517-212153-jzhou-362ae64fb4cc186e

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

jzhou77 commented 1 month ago

CI error CSKConflictingMoveInShards Severity="40" ErrorKind="Unset" Time="116.284665" DateTime="2024-05-17T19:16:12Z" Type="CSKConflictingMoveInShards" Machine="2.0.1.0:1" ID="6e2aa191d7710c96" DataMoveID="f39a62dcd237fbf3" Range="3fd3943f0c406b4d - 3fd7bf37358581a5" TargetShard="f39a62dcd237fbf3" CurrentShard="a5249aeb9c9bfee1" IsTSS="1" Version="192949738" ThreadID="11447944405127446514" Backtrace="addr2line -e fdbserver.debug -p -C -f -i 0x5af414d 0x5af4413 0x5aee4f4 0x370697b 0x37b0da1 0x37afb77 0x371de31 0x371be9b 0x371b2b9 0x371af7d 0x371a3d2 0x371926c 0x3718e46 0x3717154 0x2ce8138 0x2ce785c 0x2ce87f8 0x2ce829a 0x2ce4448 0x2ce3b0c 0x2102758 0x210248a 0x58b891d 0x58b81f3 0x1df03d8 0x59c8235 0x59c7d6a 0x35ee43c 0x7fb40bd31555" LogGroup="default" Roles="BK,CC,CD,CP,RV,ST,TL"/> is physical move shard error, unrelated.