Open sepeth opened 1 month ago
N/A
N/A
Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
N/A
Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
N/A
Let's check for the binding correctness in the CI after you changed the code. We have plenty of tests to make sure we do not break things, but still, not enough.
N/A
Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Hi there, please let me know if there's anything wrong. I see some tests are failing but couldn't be sure if they are related - I see they fail in some other PRs as well.
Hi there, please let me know if there's anything wrong. I see some tests are failing but couldn't be sure if they are related - I see they fail in some other PRs as well.
python3 -m joshua.joshua list --stopped
failure doesn't seem to be related to the Python changes in this PR (maybe merge with HEAD can resolve some of the failures fixed recently).
I saw some changes for bindingtester, so @xis19 can you make sure bindingtester can still pass joshua test?
Hello,
This is my first contribution to FoundationDB. I thought I could start from something simple ^-^
This change removes Python 2.7 support and six.py (resolves #11328 and #11329). Most of it is straightforward, such as
six.text_type -> str
,six.integer_types -> int
. OTOH, decisions I made:int2byte
as it is nicer to read thanstruct.Struct(">B").pack
, and it was used many times.I first tested with the class scheduling examples in the tutorial and validated that
fdb.__path__
was pointing to the fdb that I modified and installed.Then, I tested via
run_tester_loop.sh
&bindingtester.py
. This took a bit of time and required some fiddling with sources. But eventually, I got it running, and all python tests have passed. A few issues I had to overcome:bindingtester.py
is prepending a path tosys.path
, which didn't allow me to runrun_tester_loop.sh
from the source dir.bindingtester
weren't copied/built into the build tree (due to a check inbindingtester/CMakeLists.txt
). I am not sure about the implications of enabling this, but it would be nice ifbindingtester
is easier to run in case changes made to bindings. I didn't want to make assumptions and changes about this, and wanted to keep this solely for removing Python 2.7 support, but I am happy to look into this in another PR (and happy to hear your suggestions).Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)