apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store

https://apple.github.io/foundationdb/

Apache License 2.0

14.18k stars 1.29k forks source link

Correct the path where the fdb-kubernetes-monitor copies the binary into when running in sidecar mode #11428

Closed johscheuer closed 1 month ago

johscheuer commented 1 month ago

With the recent changes in the copy logic we introduced a bug in the fdb-kubernetes-monitor for the sidecar mode. The operator expects that the sidecar mode copies the files to /var/fdb/shared-binaries/bin/$version/fdbserver, e.g. /var/fdb/shared-binaries/bin/7.3.42/fdbserver for 7.3.42 but right now it copies the files to /var/fdb/shared-binaries/7.3/fdbserver and therefore upgrades are not working with the unified image.

Once those changes are merged I create PRs to back port this fix to 7.1 and 7.3.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[x] The PR has a description, explaining both the problem and the solution.
[x] The description mentions which forms of testing were done and the testing seems reasonable.
[x] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 300db7df41cb5c1e3dd908787543d9bae7258c0a
Duration 0:23:03
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 300db7df41cb5c1e3dd908787543d9bae7258c0a
Duration 0:34:31
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 300db7df41cb5c1e3dd908787543d9bae7258c0a
Duration 0:35:21
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 300db7df41cb5c1e3dd908787543d9bae7258c0a
Duration 0:46:53
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 300db7df41cb5c1e3dd908787543d9bae7258c0a
Duration 0:47:16
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 300db7df41cb5c1e3dd908787543d9bae7258c0a
Duration 1:08:42
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:25:18
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:33:58
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:40:03
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:44:06
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:46:24
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:57:22
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:24:54
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:34:31
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:47:02
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:53:58
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:54:08
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:54:50
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:21:44
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:36:43
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:46:20
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:52:21
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:21:36
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:42:47
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:46:21
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:51:33
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:21:38
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:35:10
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:40:43
Result: :x: FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:47:39
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:51:02
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:56:12
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:24:51
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:35:26
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:41:15
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:46:02
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:56:11
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f4cf5ac7bfb4e1ee2ad0d60144dcb37f131377de
Duration 0:56:35
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)