johscheuer commented 1 month ago

This change allows the fdb-kubernetes-monitor to read values from the node labels of the node where it is hosted. In order to be able to read those labels the fdb-kubernetes-monitor must have the appropriate Kubernetes RBAC permissions. Once this change is merged we have to make changes on the operator to enable this feature.

Fixes: https://github.com/FoundationDB/fdb-kubernetes-operator/issues/817 Fixes: https://github.com/FoundationDB/fdb-kubernetes-operator/issues/2041

I updated the approach in a way that it is compatible with environment variable replacements. That way the changes on the operator side are minimal (we just have to make sure we can enable/disable the read node labels setting). Then the user can make use of the environment replacement logic: https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/docs/manual/fault_domains.md#using-kubernetes-failure-zones and the benefit is, that this will also work to inject custom localities, e.g. for three data hall.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[x] The PR has a description, explaining both the problem and the solution.
[x] The description mentions which forms of testing were done and the testing seems reasonable.
[x] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: d7d92786a3e0fc0bb43a92c148a06b3211d5406b
Duration 0:24:52
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: d7d92786a3e0fc0bb43a92c148a06b3211d5406b
Duration 0:46:37
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: d7d92786a3e0fc0bb43a92c148a06b3211d5406b
Duration 0:48:21
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: d7d92786a3e0fc0bb43a92c148a06b3211d5406b
Duration 0:53:41
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 9013d8c077c637e8d95f00a6fdd85cc87ff276d8
Duration 0:24:37
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 3421b097acd5cc4da9f81a045e325213fb557b76
Duration 0:23:57
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 9013d8c077c637e8d95f00a6fdd85cc87ff276d8
Duration 0:34:42
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 9013d8c077c637e8d95f00a6fdd85cc87ff276d8
Duration 0:47:43
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 9013d8c077c637e8d95f00a6fdd85cc87ff276d8
Duration 0:49:46
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 9013d8c077c637e8d95f00a6fdd85cc87ff276d8
Duration 0:51:52
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 3421b097acd5cc4da9f81a045e325213fb557b76
Duration 0:46:06
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 3421b097acd5cc4da9f81a045e325213fb557b76
Duration 0:48:28
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 9013d8c077c637e8d95f00a6fdd85cc87ff276d8
Duration 0:55:50
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 month ago