apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store

https://apple.github.io/foundationdb/

Apache License 2.0

14.18k stars 1.29k forks source link

Add TLS support to fdb kubernetes monitor #11460

Closed nicmorales9 closed 2 weeks ago

nicmorales9 commented 2 weeks ago

This adds TLS support to the HTTP endpoint on the fdb kubernetes monitor. This endpoint is for prometheus metrics and potentially pprof. If a user supplies either a cert or key to the FDB k8s monitor, it will try to create a HTTPS server instead of a plain HTTP server.

This was tested by spinning up pods with this image and with TLS enabled, then curling the HTTP endpoint and verifying that it was HTTPS and was presenting the given cert. I also double checked that metrics were scrapable still with HTTPS on.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[X] The PR has a description, explaining both the problem and the solution.
[X] The description mentions which forms of testing were done and the testing seems reasonable.
[X] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: b11499051fba3acebd151ce1c8822f570ef72082
Duration 0:07:46
Result: :x: FAILED
Error: reference not found for primary source and source version b11499051fba3acebd151ce1c8822f570ef72082
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: b11499051fba3acebd151ce1c8822f570ef72082
Duration 0:08:34
Result: :x: FAILED
Error: reference not found for primary source and source version b11499051fba3acebd151ce1c8822f570ef72082
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: b11499051fba3acebd151ce1c8822f570ef72082
Duration 0:08:45
Result: :x: FAILED
Error: reference not found for primary source and source version b11499051fba3acebd151ce1c8822f570ef72082
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: b11499051fba3acebd151ce1c8822f570ef72082
Duration 0:09:04
Result: :x: FAILED
Error: reference not found for primary source and source version b11499051fba3acebd151ce1c8822f570ef72082
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: b11499051fba3acebd151ce1c8822f570ef72082
Duration 0:09:15
Result: :x: FAILED
Error: reference not found for primary source and source version b11499051fba3acebd151ce1c8822f570ef72082
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: b11499051fba3acebd151ce1c8822f570ef72082
Duration 0:10:06
Result: :x: FAILED
Error: reference not found for primary source and source version b11499051fba3acebd151ce1c8822f570ef72082
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: b11499051fba3acebd151ce1c8822f570ef72082
Duration 0:10:13
Result: :x: FAILED
Error: reference not found for primary source and source version b11499051fba3acebd151ce1c8822f570ef72082
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: fec08cbf1c0ed166cc5c4e051db6c16379ae2172
Duration 0:21:15
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: fec08cbf1c0ed166cc5c4e051db6c16379ae2172
Duration 0:49:10
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: fec08cbf1c0ed166cc5c4e051db6c16379ae2172
Duration 0:51:34
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: fec08cbf1c0ed166cc5c4e051db6c16379ae2172
Duration 0:52:02
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: fec08cbf1c0ed166cc5c4e051db6c16379ae2172
Duration 0:59:58
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 55d64cc5944fa1b59842179e45a99c02bf579a96
Duration 0:22:56
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 55d64cc5944fa1b59842179e45a99c02bf579a96
Duration 0:36:21
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 55d64cc5944fa1b59842179e45a99c02bf579a96
Duration 0:47:17
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 55d64cc5944fa1b59842179e45a99c02bf579a96
Duration 0:50:29
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 55d64cc5944fa1b59842179e45a99c02bf579a96
Duration 0:52:47
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 55d64cc5944fa1b59842179e45a99c02bf579a96
Duration 1:02:08
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 55d64cc5944fa1b59842179e45a99c02bf579a96
Duration 1:14:05
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 147f5646cbd974338d5c369f3724c587a4916f00
Duration 0:22:22
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 147f5646cbd974338d5c369f3724c587a4916f00
Duration 0:34:12
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: d5b523d62e9ca178e4881daad6007c7eae517290
Duration 0:24:01
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 147f5646cbd974338d5c369f3724c587a4916f00
Duration 0:47:17
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 147f5646cbd974338d5c369f3724c587a4916f00
Duration 0:48:53
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 491ea62c94c8012ed14ee79343d8c008cb36691e
Duration 0:26:42
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 147f5646cbd974338d5c369f3724c587a4916f00
Duration 0:54:22
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 147f5646cbd974338d5c369f3724c587a4916f00
Duration 0:55:58
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 147f5646cbd974338d5c369f3724c587a4916f00
Duration 0:58:32
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: d5b523d62e9ca178e4881daad6007c7eae517290
Duration 0:50:22
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 491ea62c94c8012ed14ee79343d8c008cb36691e
Duration 0:49:34
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: d5b523d62e9ca178e4881daad6007c7eae517290
Duration 0:53:47
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: d5b523d62e9ca178e4881daad6007c7eae517290
Duration 0:59:15
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 491ea62c94c8012ed14ee79343d8c008cb36691e
Duration 0:56:01
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 491ea62c94c8012ed14ee79343d8c008cb36691e
Duration 0:56:41
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: d5b523d62e9ca178e4881daad6007c7eae517290
Duration 1:07:57
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 491ea62c94c8012ed14ee79343d8c008cb36691e
Duration 1:06:11
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)