apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.18k stars 1.29k forks source link

Refactor ChangeFeedCommand.actor.cpp for Readability and Modularization #11461

Open sanowl opened 2 weeks ago

sanowl commented 2 weeks ago

*Modularized Code**: Separated command handling into individual functions (handleStreamCommand, handlePopCommand).

  1. Consistent Error Handling: Improved error handling across functions with detailed error messages.
  2. Enhanced Readability: Added comments and improved code structure for better readability.
  3. Namespace Usage: Encapsulated helper functions within an unnamed namespace for better encapsulation.
foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

xis19 commented 2 weeks ago

FYI: I have sent you a pull request to your repo for the source formatting issue.