apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.18k stars 1.29k forks source link

Replica comparison error message cleanup #11467

Closed sbodagala closed 2 weeks ago

sbodagala commented 2 weeks ago

Do not refer to TSS when logging error/trace messages in the context of replica comparison.

Testing:

Joshua job:

20240618-164125-sre-1bd7af425d6bb76b (shows test failures but it is unlikely they were caused by this change set).

20240618-182439-sre-1bd7af425d6bb76b (shows a "cacheTest.toml" failing, again it is unlikely that was caused by this change set).

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 2 weeks ago

Result of foundationdb-pr on Linux CentOS 7