apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.18k stars 1.29k forks source link

fix: resolve missing CopyJavaDoc target #11475

Open kris-hansen opened 1 week ago

kris-hansen commented 1 week ago

This pull request addresses a build error encountered when enabling documentation generation for the FoundationDB project. The error is related to a missing CopyJavadoc target in the CMakeLists.txt file. The build error is as follows:

CMake Error at CMakeLists.txt:218 (add_dependencies):
  The dependency target "CopyJavadoc" of target "html" does not exist.

Solution: Added a custom target named CopyJavadoc that uses the cmake -E copy_directory command to copy Javadoc files from the sphinx directory to the build directory. This target is now correctly referenced as a dependency for the html target, ensuring that the build process completes successfully.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

foundationdb-ci commented 5 days ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented 5 days ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented 5 days ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 5 days ago

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented 5 days ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 5 days ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 5 days ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7