apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.5k stars 1.31k forks source link

check correct version in getMappedKeyValuesQ #11729

Closed dlambrig closed 1 week ago

dlambrig commented 1 week ago

Requests to the storage server validate the version calculated by waitForVersion(), not the one in the request. This rule was not followed in getMappedKeyValuesQ(), as it was elsewhere (getKeyValuesQ(), getValueQ, getKeyValuesStreamQ(), etc.), leading to an assert in checkTenantEntry().

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

foundationdb-ci commented 1 week ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

foundationdb-ci commented 1 week ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented 1 week ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented 1 week ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

foundationdb-ci commented 1 week ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented 1 week ago

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented 1 week ago

Result of foundationdb-pr on Linux CentOS 7