dlambrig commented 6 hours ago

Do not check for PROXY_USE_RESOLVER_PRIVATE_MUTATIONS in rangeLockEnabled

Joshua with PROXY_USE_RESOLVER_PRIVATE_MUTATIONS enabled and ENABLE_READ_LOCK_ON_RANGE disabled:

20241104-211756-dlambrig-a5cb3b9fac7ed2ca

with ENABLE_READ_LOCK_ON_RANGE and PROXY_USE_RESOLVER_PRIVATE_MUTATIONS enabled:

20241104-231600-dlambrig-bfad63339bc07b5e

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[ ] The PR has a description, explaining both the problem and the solution.
[ ] The description mentions which forms of testing were done and the testing seems reasonable.
[ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

kakaiu commented 6 hours ago

LGTM. Note that currently the two rangeLocking simulation test (tests/fast/RangeLockCycle.toml and tests/fast/RangeLocking.toml) disable PROXY_USE_RESOLVER_PRIVATE_MUTATIONS in the toml file. We can re-enable the feature in the two tests once the PR of removing duplicated functions in Resolver.actor.cpp has been merged.

foundationdb-ci commented 6 hours ago

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 7f8151c9ac5e0dc67d74e6cc3c846a57465ccf8b
Duration 0:23:34
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 6 hours ago

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 7f8151c9ac5e0dc67d74e6cc3c846a57465ccf8b
Duration 0:47:48
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 6 hours ago

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 7f8151c9ac5e0dc67d74e6cc3c846a57465ccf8b
Duration 0:48:49
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 6 hours ago

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 7f8151c9ac5e0dc67d74e6cc3c846a57465ccf8b
Duration 0:50:33
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 5 hours ago

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 7f8151c9ac5e0dc67d74e6cc3c846a57465ccf8b
Duration 0:51:31
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 5 hours ago

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 7f8151c9ac5e0dc67d74e6cc3c846a57465ccf8b
Duration 0:53:25
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci commented 5 hours ago

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 7f8151c9ac5e0dc67d74e6cc3c846a57465ccf8b
Duration 1:13:25
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

dlambrig commented 3 hours ago

LGTM. Note that currently the two rangeLocking simulation test (tests/fast/RangeLockCycle.toml and tests/fast/RangeLocking.toml) disable PROXY_USE_RESOLVER_PRIVATE_MUTATIONS in the toml file. We can re-enable the feature in the two tests once the PR of removing duplicated functions in Resolver.actor.cpp has been merged.

There are only two functions and one data structure to deduplicate. Conceptually I do not think there is a good reason why your change would not work on the resolver, but if there is a problem I'll see if it can be fixed.

Joshua ran clean when I enabled both knobs after modifying the toml files. I'll test a bit more to be sure.

foundationdb-ci commented 3 hours ago