apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.38k stars 1.3k forks source link

Add debug tools to the runtime docker image #2386

Closed apkar closed 2 years ago

apkar commented 4 years ago

Docker image that is being published has a very minimal set of tools. It would be useful to ship some useful debug tools with the image. We should add useful, at the same time not make the image too big. I can think of some tools that could be useful

May be useful

atn34 commented 4 years ago

Let's add ubsan too, so we can build with -DUSE_UBSAN=1 in the docker image

mpilman commented 4 years ago

some more tools I think would be useful:

apkar commented 4 years ago

Let's add ubsan too, so we can build with -DUSE_UBSAN=1 in the docker image

@atn34 if I understand correctly, you are asking for ubsan in build image, right? I was mainly talking about FDB runtime docker image.

atn34 commented 4 years ago

Yup I was talking about the build Image

On Thu, Dec 5, 2019 at 12:14 AM Bhaskar Muppana notifications@github.com wrote:

Let's add ubsan too, so we can build with -DUSE_UBSAN=1 in the docker image

@atn34 https://github.com/atn34 if I understand correctly, you are asking for ubsan in build image, right? I was mainly talking about FDB runtime docker image.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/apple/foundationdb/issues/2386?email_source=notifications&email_token=AARO7B2WGNNFQ7OWLPPJ3M3QXCZ6VA5CNFSM4JQXUNWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF737VI#issuecomment-562020309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARO7B3U7L7VXAAE7WRERDDQXCZ6VANCNFSM4JQXUNWA .

johscheuer commented 3 years ago

@apkar is the idea to always contain these debugging tools in the image or should we release 2 different images e.g. one $FDB-VERSION-debug and the current one?

apkar commented 3 years ago

@apkar is the idea to always contain these debugging tools in the image or should we release 2 different images e.g. one $FDB-VERSION-debug and the current one?

Sorry for super late response. Idea is to have them all the time in the image. I checked locally, these tools seems to increase the image size by 100MB. I think, with container caching various platforms do, 100MB increase in image size is not too much cost for the benefits we get in return.

ammolitor commented 2 years ago

This is super old, closing.