search

apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.33k stars 1.3k forks source link

Setting invalid TLS cert path does not yield error in 6.2.20 #3315

Open kirilltitov opened 4 years ago

kirilltitov commented 4 years ago

I'm maintainer of a library FDBSwift, and yesterday (after upgrading my local FoundationDB server and client) I noticed that one of my tests is failing, the one that tests that providing an invalid (non-existent) TLS cert path as FDB_NET_OPTION_TLS_CERT_PATH network option yields an error.

Ultimately it expects fdb_network_set_option to return a non-zero fdb_error_t for obviously invalid options arguments (on high-level it's a Swift Error, of course).

However, in FoundationDB 6.2.20 it does not return an error code anymore (just zero), whereas in version 6.2.7, which I had prior to upgrade, fdb_network_set_option returns code 1513 (File could not be read).

Same for FDB_NET_OPTION_TLS_CERT_BYTES option (expected code 2107), didn't test other options.

kirilltitov commented 2 years ago

Any updates on this? Prod is already 6.3, but it's still an issue. Skipped test annoys me :)

c4pQ commented 5 months ago

I'm using 7.1 and also faced similar issue.

Is there any way to understand client has TLS-related issues despite looking into logs?