search

apple / foundationdb

FoundationDB - the open source, distributed, transactional key-value store
https://apple.github.io/foundationdb/
Apache License 2.0
14.5k stars 1.31k forks source link

CI does not test non-TLS build #5153

Closed sfc-gh-tclinkenbeard closed 2 years ago

sfc-gh-tclinkenbeard commented 3 years ago

People are relying on the non-TLS build (see https://github.com/apple/foundationdb/issues/5148), but it is not currently tested in CI.

ammolitor commented 2 years ago

This issue makes an accurate statement. It, however, does not make a request to change anything.

sfc-gh-tclinkenbeard commented 2 years ago

Does not make a request to change anything.

The request is to add a step to CI that builds with the option -DDISABLE_TLS=ON.

jzhou77 commented 2 years ago

The consensus is to require TLS for FDB build.