apple / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Apple’s stable releases of Clang as well as support the Swift project.
https://llvm.org
Other
1.1k stars 320 forks source link

[ThinLTO] Re-commit termination handling #8840

Closed jansvoboda11 closed 1 month ago

jansvoboda11 commented 1 month ago

Asynchronous ThinLTO caching was originally implemented in https://github.com/apple/llvm-project/pull/8236 (and cherry-picked into the release branch in https://github.com/apple/llvm-project/pull/8614), but the Make the async code more self-contained commit accidentally dropped termination handling. This resulted in a crash in the "LLVM.CAS.thinlto-remote-cache.ll" test. This PR fixes that.

jansvoboda11 commented 1 month ago

@swift-ci please test

jansvoboda11 commented 1 month ago

@swift-ci please test