search

apple / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Apple’s stable releases of Clang as well as support the Swift project.
https://llvm.org
Other
1.1k stars 320 forks source link

[lldb] Uncomment LogUnimplementedTypeKind in GetEnumCaseName #8852

Closed augusto2112 closed 4 weeks ago

augusto2112 commented 4 weeks ago

There are two commits in this PR:

[lldb] Uncomment LogUnimplementedTypeKind in GetEnumCaseName

GetEnumCaseName now passes the test suite without failing. Uncomment the
log in it.

rdar://122506593
[lldb] UpdateFormatsIfNeeded should respect the dynamic value type

UpdateFormatsIfNeeded has hardcoded the call to GetFormat with no
dynamic values. GetFormat will try to find the synthetic children of the
ValueObject, and passing the wrong one can fail, which can be bad for
performance but should not be user visible. Fix the performace bug by
passing the dynamic value type of the ValueObject.

rdar://122506593
(cherry picked from commit d698ba1ce41d04526dfc2d8abe69c673d524afa4)
augusto2112 commented 4 weeks ago

@swift-ci test