apple / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Apple’s stable releases of Clang as well as support the Swift project.
https://llvm.org
Other
1.09k stars 320 forks source link

[lldb] Give more time to test/API/multiple-debuggers #8913

Closed felipepiovezan closed 1 day ago

felipepiovezan commented 2 weeks ago

This test occasionally fails on two of the busiest CI bots (asan and matrix), and we can't reproduce it locally. This leads to the hypothesis that the test is timing out (in the sense of the number of "join attempts" performed by this test's driver).

This commit doubles the number of iterations performed and also does an NFC refactor of the main test loop so that it can be more easily understood.

adrian-prantl commented 2 weeks ago

Forgot to say — this looks very promising!

adrian-prantl commented 1 week ago

I landed a variant of this in 869f5517605224944d6037716e234d9f1f0e7067.