apple / ml-cvnets

CVNets: A library for training computer vision networks
https://apple.github.io/ml-cvnets
Other
1.76k stars 225 forks source link

bug in coco_ssd.py #76

Closed MLRadfys closed 11 months ago

MLRadfys commented 1 year ago

Hi,

I noticed a small mistake in the coco_ssd.py script.

In def getitem(...):

boxes, labels = self.get_boxes_and_labels( image_id=image_id, image_width=im_width, image_height=im_height )

self.get_boxes_and_labels() returns boxes, labels and masks (or None) and should be changed to:

boxes, labels, _ = self.get_boxes_and_labels( image_id=image_id, image_width=im_width, image_height=im_height )

Cheers,

M

darwinharianto commented 1 year ago

https://github.com/apple/ml-cvnets/blob/c668ad13d67b3e8829e810d4b6e16ad7f77fd4aa/data/datasets/detection/coco_ssd.py#L158

it looks correct

mchorton commented 11 months ago

Marking resolved per @darwinharianto’s comment