search

apple / ml-mdm

Train high-quality text-to-image diffusion models in a data & compute efficient manner
https://machinelearning.apple.com/research/matryoshka-diffusion-models
MIT License
444 stars 31 forks source link

Update `cc12m_256x256.yaml` with diffusion_config addition and use `null` as a correct version of `None` #13

Closed tolgacangoz closed 1 month ago

tolgacangoz commented 2 months ago

Proposes to fix #10

  1. This pull request updates the cc12m_256x256.yaml and cc12m_1024x1024.yaml files by adding a diffusion_config section because samplers are created with diffusion_config.sampler_config: https://github.com/apple/ml-mdm/blob/36959179b5c103cfe014c2ddaef91c6a24feefbe/ml_mdm/diffusion.py#L94 https://github.com/apple/ml-mdm/blob/36959179b5c103cfe014c2ddaef91c6a24feefbe/ml_mdm/diffusion.py#L287

  2. Also, diffusion_config.no_use_residual is needed: https://github.com/apple/ml-mdm/blob/36959179b5c103cfe014c2ddaef91c6a24feefbe/ml_mdm/diffusion.py#L262

  3. None in the file is read by 'None' -as a string.

@jlukecarlson