Closed tolgacangoz closed 5 days ago
https://github.com/apple/ml-mdm/pull/21
Thanks @tolgacangoz I think your PR fixed most of the issues. Please check the above my proposal (i think it did not fix the typos you mentioned)
This PR now fixes some small nits.
Proposes to fix #10
This pull request updates the
cc12m_256x256.yaml
andcc12m_1024x1024.yaml
files by adding adiffusion_config
section because samplers are created withdiffusion_config.sampler_config
: https://github.com/apple/ml-mdm/blob/36959179b5c103cfe014c2ddaef91c6a24feefbe/ml_mdm/diffusion.py#L94 https://github.com/apple/ml-mdm/blob/36959179b5c103cfe014c2ddaef91c6a24feefbe/ml_mdm/diffusion.py#L287Also,
diffusion_config.no_use_residual
is needed: https://github.com/apple/ml-mdm/blob/36959179b5c103cfe014c2ddaef91c6a24feefbe/ml_mdm/diffusion.py#L262None
in the file is read by'None'
-as a string.Proposes to fix #6
Fixes old module mimicry.
This pull request proposes a refactoring of the
samplers.py
file to ensure correct handling of scaling when theconfig.schedule_shifted
flag is set toTrue
. This change improves the behavior of the code, especially for higher resolutions.a blue jay stops on the top of a helmet of Japanese samurai, background with sakura tree
Guidance scale =7.5
Thresholding =clip
Number of steps =250
Before 1024x1024@MultiPath @Shuangfei @luke-carlson