Add Air France KLM FlyingBlue shared credentials

apple / password-manager-resources

A place for creators and users of password managers to collaborate on resources to make password management better.

MIT License

4.23k stars 455 forks source link

Add Air France KLM FlyingBlue shared credentials #624

Closed JulienParis86 closed 2 years ago

JulienParis86 commented 2 years ago

Overall Checklist

[x] I agree to the project's Developer Certificate of Origin
[x] The top-level JSON objects are sorted alphabetically
[x] There are no open pull requests for the same update

for shared-credentials.json

[x] There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
[x] If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
[ ] If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

Sameesunkaria commented 2 years ago

Hi,

Since you have added the "login" subdomain variants for the three domains to shared-credentials.json, you should remove the domains from shared-credentials-historical.json. You will also need to update websites-with-shared-credential-backends.json by running tools/convert-shared-credential-to-legacy-format.rb.

About the failed CI job: The shared-credentials.json should be sorted alphabetically. Currently, domains starting with the letter L (login...) are grouped with domains starting with the letter A.

JulienParis86 commented 2 years ago

Thanks @Sameesunkaria for your help understanding my mistake :)

Sameesunkaria commented 2 years ago

For record keeping purposes:

At the time of this comment, the login.airfrance.com and login.klm.com map to the same CNAME record and all three domains resolve to the same IP addresses:

login.airfrance.com canonical name = login.airfrance.com.edgekey.net.
login.airfrance.com.edgekey.net canonical name = e77721.a.akamaiedge.net.
Name:   e77721.a.akamaiedge.net
Address: 88.221.221.168
Name:   e77721.a.akamaiedge.net
Address: 88.221.221.146

login.klm.com   canonical name = login.klm.com.edgekey.net.
login.klm.com.edgekey.net   canonical name = e77721.a.akamaiedge.net.
Name:   e77721.a.akamaiedge.net
Address: 88.221.221.168
Name:   e77721.a.akamaiedge.net
Address: 88.221.221.146

login.flyingblue.com    canonical name = login.flyingblue.com.edgekey.net.
login.flyingblue.com.edgekey.net    canonical name = e77721.dsca.akamaiedge.net.
Name:   e77721.dsca.akamaiedge.net
Address: 88.221.221.168
Name:   e77721.dsca.akamaiedge.net
Address: 88.221.221.146

Sameesunkaria commented 2 years ago

Thank you @JulienParis86 The changes look good to me :)

Sameesunkaria commented 2 years ago

Screenshots of the pages:

Air France login page accepting a Flying Blue number

KLM login page accepting a Flying Blue number