apple / password-manager-resources

A place for creators and users of password managers to collaborate on resources to make password management better.
MIT License
4.14k stars 445 forks source link

Instagram & Threads.net #711

Closed ezfe closed 1 year ago

ezfe commented 1 year ago

Overall Checklist

for shared-credentials.json

Threads.net shown below: Screenshot 2023-08-25 at 13 48 29@2x

calebd commented 1 year ago

@ezfe please update quirks/shared-credentials.json instead, then run tools/convert-shared-credential-to-legacy-format.rb. That will update the other file. Also please include the full PR template for shared credentials:

#### for shared-credentials.json
- [x] There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
- [x] If using `shared`, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a `shared` association from `google.co.il` to `google.com`, because `google.co.il` redirects to `accounts.google.com` for sign in.)
- [ ] If using `from` and `to`, the new group, the `from` domain(s) redirect to the `to` domain to log in.
ezfe commented 1 year ago

Thanks - yeah I figured that out, trying to commit it

calebd commented 1 year ago

Thank you @ezfe!