Closed ezfe closed 1 year ago
@ezfe please update quirks/shared-credentials.json
instead, then run tools/convert-shared-credential-to-legacy-format.rb
. That will update the other file. Also please include the full PR template for shared credentials:
#### for shared-credentials.json
- [x] There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
- [x] If using `shared`, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a `shared` association from `google.co.il` to `google.com`, because `google.co.il` redirects to `accounts.google.com` for sign in.)
- [ ] If using `from` and `to`, the new group, the `from` domain(s) redirect to the `to` domain to log in.
Thanks - yeah I figured that out, trying to commit it
Thank you @ezfe!
Overall Checklist
for shared-credentials.json
shared
, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use ashared
association fromgoogle.co.il
togoogle.com
, becausegoogle.co.il
redirects toaccounts.google.com
for sign in.)from
andto
, the new group, thefrom
domain(s) redirect to theto
domain to log in.Threads.net shown below:![Screenshot 2023-08-25 at 13 48 29@2x](https://github.com/apple/password-manager-resources/assets/1449259/bcef4e8b-92a5-4ab7-933b-14d95b32853c)