added DriveThru sites as shared credentials - Githubissues

apple / password-manager-resources

A place for creators and users of password managers to collaborate on resources to make password management better.

MIT License

4.14k stars 445 forks source link

added DriveThru sites as shared credentials #714

Open mpanighetti opened 11 months ago

mpanighetti commented 11 months ago

added DriveThru sites as shared credentials (confirmed firsthand that all these sites use a shared account, as they are part of the "DriveThru family of sites")

Overall Checklist

[x] I agree to the project's Developer Certificate of Origin
[x] The top-level JSON objects are sorted alphabetically
[x] There are no open pull requests for the same update

for shared-credentials.json

[x] There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
[x] If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)

rmondello commented 11 months ago

Run ruby tools/convert-shared-credential-to-legacy-format.rb --verify
  ruby tools/convert-shared-credential-to-legacy-format.rb --verify
  shell: /usr/bin/bash -e {0}
ERROR: websites-with-shared-credential-backends.json is not up-to-date. Please run this script again and commit the changes.
Error: Process completed with exit code 1.

Please run tools/convert-shared-credential-to-legacy-format.rb and commit the result of that. (Sorry about this! We should automate that somehow.)

mpanighetti commented 11 months ago

Thanks! Added a few more sites to the same shared credential set and ran the fixer script, should be good to test now.